Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

expose the fields of Dust type to public #14388

Merged
merged 1 commit into from
Jun 18, 2023
Merged

expose the fields of Dust type to public #14388

merged 1 commit into from
Jun 18, 2023

Conversation

wangjj9219
Copy link
Contributor

I'm using latest fungibles traits, for some reason I need to overwrite Unbalanced::increase_balance in my impl, but I found that the fielde of Dust type is invisible, and has no constructor and getter function.

@wangjj9219 wangjj9219 requested review from a team June 14, 2023 15:38
@wangjj9219 wangjj9219 mentioned this pull request Jun 14, 2023
Open
@xlc
Copy link
Contributor

xlc commented Jun 14, 2023

can we also have this back ported to v0.9.42 and v0.9.43

@bkchr bkchr requested a review from a team June 15, 2023 10:42
gilescope
gilescope approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed it's really hard if you can't get at the dust value.

@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 18, 2023
@ggwpez
Copy link
Member

ggwpez commented Jun 18, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9fc3fd0 into paritytech:master Jun 18, 2023
@ggwpez
Copy link
Member

ggwpez commented Jun 18, 2023

can we also have this back ported to v0.9.42 and v0.9.43

^ @coderobe

rossbulat pushed a commit that referenced this pull request Jun 19, 2023
@wangjj9219
expose the fields of Dust type to public (#14388)
395885e
@xlc
Copy link
Contributor

xlc commented Jun 22, 2023

@bkchr @ggwpez @coderobe can we also have this back ported to v0.9.42 and v0.9.43?

bkchr pushed a commit that referenced this pull request Jun 22, 2023
@wangjj9219 @bkchr
expose the fields of Dust type to public (#14388)
ff24c60
bkchr pushed a commit that referenced this pull request Jun 22, 2023
@wangjj9219 @bkchr
expose the fields of Dust type to public (#14388)
5e49f6e
@bkchr
Copy link
Member

bkchr commented Jun 22, 2023

@xlc done

Agusrodri pushed a commit to moonbeam-foundation/substrate that referenced this pull request Jul 13, 2023
@wangjj9219 @Agusrodri
expose the fields of Dust type to public (paritytech#14388)
dce0012
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@wangjj9219 @nathanwhit
expose the fields of Dust type to public (paritytech#14388)
423e34c
@dmitrylavrenov dmitrylavrenov mentioned this pull request Oct 29, 2024
Open
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@juangirini juangirini juangirini approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangjj9219 @xlc @ggwpez @bkchr @gilescope @juangirini